Update Linting and Formatting to use Ruff instead
#273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
may fail a lot for now though Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #273 +/- ##
===========================================
+ Coverage 92.18% 93.21% +1.02%
===========================================
Files 23 23
Lines 576 575 -1
===========================================
+ Hits 531 536 +5
+ Misses 45 39 -6
☔ View full report in Codecov by Sentry. |
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
crashes if the 204 function is annotated with return 'None' and future annotations is imported Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
there is zero coverage for this atm, which is briging the API coverage right down. The next PR will test that functionality and re-enable Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
(integration tests still disabled) Signed-off-by: Grant Ramsay <seapagan@gmail.com>
imports like this should be excluded from coverage Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Signed-off-by: Grant Ramsay <seapagan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases development speed across the board and reduces many dev dependencies. As a result, the entire app should be typed appropriately, too.
The codebase is adjusted in this PR to pass all the linting errors, which was a more significant undertaking! I have set
Ruffto be very strict, with a few exceptions as needed. Mypy also passes onstrictmode for the whole codebase.For this PR, the CLI functionality is omitted from test coverage as it has zero tests, bringing the overall coverage total down. The very next PR will fix this.
There is also a new GitHub Actions task to Lint and Format check the code on any push or PR