Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix append_text_comment rule to not add an extra space #231

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

jeparlefrancais
Copy link
Contributor

@jeparlefrancais jeparlefrancais commented Nov 22, 2024

Closes #199

Remove the extra space that is added in front of comments. This makes it possible to generate comments like --!native which are useful in Luau.

  • add entry to the changelog

Copy link

Coverage after merging fix-append-text-space-padding into main will be

86.09%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src/rules
   append_text_comment.rs51.75%100%69.23%50.69%118–125, 141–154, 160–171, 177–186, 192–201, 207–223, 229–240, 246–253, 259–267, 282–300, 321–328, 331–333, 335–337, 347–348, 350–351, 360–362, 366–368, 37, 370–371, 379, 38, 380, 385–389, 39, 390–393, 40, 406–407, 41, 413–419, 42, 420, 43, 450–455, 482–498, 505–507, 54, 56–59, 72–73

@jeparlefrancais jeparlefrancais merged commit c189e63 into main Nov 22, 2024
6 checks passed
@jeparlefrancais jeparlefrancais deleted the fix-append-text-space-padding branch November 22, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better append_text_comment rule content/context awareness.
1 participant