Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative zero sign erasure #222

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Fix negative zero sign erasure #222

merged 2 commits into from
Oct 21, 2024

Conversation

jeparlefrancais
Copy link
Contributor

@jeparlefrancais jeparlefrancais commented Oct 21, 2024

Closes #216

This avoids the issue were the evaluator was replacing -0 results with only 0.

  • add entry to the changelog

Copy link

Coverage after merging preserve-zero-sign into main will be

87.04%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
src/nodes/expressions
   mod.rs76.29%100%75.68%76.43%138–140, 144–146, 150–152, 156–158, 162–164, 168–170, 186–188, 192–194, 270, 322–325, 327, 92–97
src/process/evaluator
   mod.rs88.01%100%98.18%86.80%102–103, 164, 176, 187, 198, 207–209, 217, 219–221, 223–224, 227, 239–241, 253–257, 261–262, 264–266, 306, 327, 341, 365, 368, 401, 407–408, 413, 427, 430, 448, 552, 556, 58–60, 71, 827, 88–89

@jeparlefrancais jeparlefrancais merged commit 9cbf20d into main Oct 21, 2024
6 checks passed
@jeparlefrancais jeparlefrancais deleted the preserve-zero-sign branch October 21, 2024 03:26
jackTabsCode pushed a commit to jackTabsCode/darklua that referenced this pull request Oct 27, 2024
This avoids bugs were the evaluator was replacing `-0` results with
only `0`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve sign when evaluating zero
1 participant