Move the disconnectedCallback() call

The fix introduced in [hotwired#454][] resolved the issue, but introduced a matching `disconnectedCallback()` far-off in the `FrameRenderer`. This commit moves that call to occur _immediately_ after it's paired `element.connectedCallback()`. [hotwired#454]: hotwired#454
seanpdoyle · Nov 18, 2021 · 7cae7cd · 7cae7cd
1 parent 774b4b9
commit 7cae7cd
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/src/core/frames/frame_controller.ts b/src/core/frames/frame_controller.ts
@@ -439,6 +439,7 @@ function activateElement(element: Element | null, currentURL?: string | null) {
 
     if (element instanceof FrameElement) {
       element.connectedCallback()
+      element.disconnectedCallback()
       return element
     }
   }

diff --git a/src/core/frames/frame_renderer.ts b/src/core/frames/frame_renderer.ts
@@ -29,7 +29,6 @@ export class FrameRenderer extends Renderer<FrameElement> {
     if (sourceRange) {
       sourceRange.selectNodeContents(frameElement)
       this.currentElement.appendChild(sourceRange.extractContents())
-      frameElement.disconnectedCallback()
     }
   }