Fix turbo:load firing twice after a redirect and avoid double render (

hotwired#563)

* Avoid firing turbo:load twice after a redirect

* Fix lint violations

* Correct reference

* New API

Co-authored-by: Felipe <felipe@temporadalivre.com>
Co-authored-by: David Heinemeier Hansson <david@hey.com>

src/core/drive/visit.ts

@@ -157,9 +157,12 @@ export class Visit implements FetchRequestDelegate {
     if (this.state == VisitState.started) {
       this.recordTimingMetric(TimingMetric.visitEnd)
       this.state = VisitState.completed
-      this.adapter.visitCompleted(this)
-      this.delegate.visitCompleted(this)
       this.followRedirect()
+
+      if (!this.followedRedirect) {
+        this.adapter.visitCompleted(this)
+        this.delegate.visitCompleted(this)
+      }
     }
   }
 

src/tests/functional/navigation_tests.ts

@@ -334,6 +334,16 @@ test("test double-clicking on a link", async ({ page }) => {
   assert.equal(await visitAction(page), "advance")
 })
 
+test("test does not fire turbo:load twice after following a redirect", async ({ page }) => {
+  page.click("#redirection-link")
+
+  await nextBeat() // 301 redirect response
+  await noNextEventNamed(page, "turbo:load")
+  await nextBeat() // 200 response
+  await nextBody(page)
+  await nextEventNamed(page, "turbo:load")
+})
+
 test("test navigating back whilst a visit is in-flight", async ({ page }) => {
   page.click("#delayed-link")
   await nextEventNamed(page, "turbo:before-render")