Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with ember-cli-rails #4

Merged
merged 2 commits into from
Dec 20, 2015
Merged

Conversation

seanpdoyle
Copy link
Owner

Restructure module

  • Rename EmberCLI to EmberCli
  • Restructure files, moving ember-cli to ember_cli

Integrate with ember-cli-rails

EmberCLI-Rails supports configuring alternative deployment strategies.

Modify the gem to properly expose itself as a deployment strategy.

end

def deploy_key
key = redis_client.get(current_key).presence || deployment_not_activated!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [81/80]

@seanpdoyle seanpdoyle force-pushed the ember-cli-rails-deploy branch 2 times, most recently from ba3adbe to c2f5edf Compare December 13, 2015 05:52

def deploy_key
key = redis_client.get(current_key).presence ||
deployment_not_activated!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Align the operands of an expression in an assignment spanning multiple lines.

* Rename `EmberCLI` to `EmberCli`
* Restructure files, moving `ember-cli` to `ember_cli`
@seanpdoyle seanpdoyle force-pushed the ember-cli-rails-deploy branch 5 times, most recently from 7b5323e to 74b00b7 Compare December 19, 2015 15:27
EmberCLI-Rails supports configuring alternative [deployment strategies].

Modify the gem to properly expose itself as a deployment strategy.

[deployment strategies]:https://github.com/thoughtbot/ember-cli-rails#deployment-strategies
@seanpdoyle seanpdoyle force-pushed the ember-cli-rails-deploy branch from 74b00b7 to eb0c587 Compare December 20, 2015 17:04
@seanpdoyle seanpdoyle merged commit eb0c587 into master Dec 20, 2015
@seanpdoyle seanpdoyle deleted the ember-cli-rails-deploy branch December 20, 2015 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants