Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

olgabot/sourmash sketch #1

Merged
merged 46 commits into from
May 18, 2024
Merged

olgabot/sourmash sketch #1

merged 46 commits into from
May 18, 2024

Conversation

olgabot
Copy link
Collaborator

@olgabot olgabot commented May 12, 2024

  • Ignore the random null/ folder that gets created
  • Get input samplesheet to work!
  • Add makefile for tests
  • Only take one fasta file from samplesheet
  • Remove fastqc
  • Got sourmash sketch to work!
  • Added kmerize target, but not working
  • Get sourmash sketch on target to work

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/kmerseek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@olgabot olgabot changed the base branch from master to dev May 12, 2024 19:27
@olgabot
Copy link
Collaborator Author

olgabot commented May 12, 2024

The failed pipeline test is :

╰──────────────────────────────────────────────────────────────────────────────╯
╭─ [✗] 1 Pipeline Test Failed ─────────────────────────────────────────────────╮
│                                                                              │
│ files_unchanged: docs/images/nf-core-kmerseek_logo_dark.png does not match   │
│ the template                                                                 │
│                                                                              │
╰──────────────────────────────────────────────────────────────────────────────╯

... which is not a "true" fail if you ask me. Gonna merge soon.

@olgabot olgabot merged commit 9b5b8dd into dev May 18, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant