#510 make facet multi-arg

seancorfield · Oct 17, 2023 · 440b866 · 440b866
1 parent 5e9bdba
commit 440b866
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/honey/sql.cljc b/src/honey/sql.cljc
@@ -1447,7 +1447,7 @@
          :returning       #'format-selects
          :with-data       #'format-with-data
          ;; NRQL extensions:
-         :facet           #'format-selector
+         :facet           #'format-selects
          :since           #'format-interval
          :until           #'format-interval
          :compare-with    #'format-interval
@@ -2331,7 +2331,7 @@
                :where [:some :value]
                #_[:and [:= :environment "production"]
                   [:= :process.name "match"]]
-               :facet [:some.metric :alias]
+               :facet [[:some.metric :alias]]
                :since [1 :day :ago]
                :timeseries [:auto]}
               {:dialect :nrql})

diff --git a/src/honey/sql/helpers.cljc b/src/honey/sql/helpers.cljc
@@ -1023,7 +1023,7 @@
 (defn facet
   "(facet [:metric.name :alias])"
   [& args]
-  (generic-1 :facet args))
+  (generic :facet args))
 
 (defn since
   "(since 2 :days :ago)"