Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(conventionalcommits): replace conform with commitlint #292

Merged
merged 1 commit into from
May 14, 2020

Conversation

priyasiddharth
Copy link
Collaborator

Conform cannot run on multiple commits(link) therefore moving to commitlint. I have let the conform config file be as-is and kept the contributing guidelines unchanged if someone wants to use conform for client side checks. I can remove all trace of conform this is the desired preference.

tested:

  1. tested that arbitrary scopes are allowed
  2. tested that all commits are checked instead of just the latest one
  3. tested that both push and pull_request run this check.

thank you
Siddharth

Conform cannot run on multiple commits therefore moving to commitlint. I have let the conform config file be as-is and kept the contributing guidelines unchanged if someone wants to use conform for client side checks. I can remove all trace of conform this is the desired preference

tested:
1. tested that arbitrary scopes are allowed
2. tested that all commits are checked instead of just the latest one
3. tested that both push and pull_request run this check.
@agurfinkel agurfinkel merged commit 4a01b6f into seahorn:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants