Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xread block and count support #194

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jun 30, 2020

No description provided.

@sds sds added the enhancement label Jul 2, 2020
@sds sds merged commit 09e2fdc into sds:master Jul 2, 2020
@ghost ghost deleted the xadd_block_count branch July 2, 2020 13:39
@@ -47,4 +47,20 @@
expect(@redises.xread([@key, @key1], %w[1234567891234-2 1234567891234-1]))
.to eq({ @key1 => [['1234567891234-2', { 'key1' => 'value2' }]] })
end

it 'supports the block parameter' do
Copy link
Author

@ghost ghost Jul 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sds I accepted the block parameter but don't do anything with it. Do you implement blocking anywhere else in the mock_redis? I had considered just doing a sleep block/1000.0 but didn't see sleep anywhere else in the code base. Of course only doing the sleep if the result was empty.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will rely on users of this library to report any issues with what you've implemented, and provide a PR fixing the logic to add the support if it is needed. Thank you!

@ghost
Copy link
Author

ghost commented Aug 25, 2020

@sds could you create a new release which incorporates this change?

@sds
Copy link
Owner

sds commented Aug 26, 2020

0.26.0 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants