Fix tag attribute spacing #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps deal with updating generated ruby when changing extractor stuff
This allows cleaner representation of tag attributes, and improved corrections. Also moved the begin...ensure of tags's to be only for its children, not the tag placeholder, nor tag attributes nor tag scripts. This may also help with performance a little by often not needing to have a begin...ensure at all.
MaxLap
force-pushed
the
fix_tag_attribute_spacing
branch
3 times, most recently
from
81e4c35 to
e78b2b5
Compare
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #485
A side benefit of this change is that we generate less Ruby for RuboCop, so maybe a bit of performance benefit.