Re-generate UDFs affected by signature::variadic_equal disappearance in DataFusion #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to regenerate UDFs affected by disappearance of Signature::variadic_equal in DataFusion
|
See #74. It was easier to re-do this after the overlooked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are re-generated UDFs adjusting to the disappearance of DataFusion's
signature::TypeSignature::VariadicEqualin apache/datafusion#10439In DataFusion's, this was replaced with the new
signature::TypeSignature::UserDefined, which comes with a new methodScalarUDFImpl::coerce_types(to be user-implemented) that DF calls to preprocess actual arguments before passing them to theinvokemethod.This is not something that is suitable to our more statically-checked setting, so this PR replaces
VariadicEqualwithVariadicAny. It's a worse approximation to SDF function signatures, but that's only important for "documentation"-like purposes; SDF typechecking and execution are not affected.