Skip to content

Commit

Permalink
Remove unneeded NullAway warning suppressions
Browse files Browse the repository at this point in the history
This commit removes warning suppressions related to uber/NullAway#1113
which is now fixed.

See spring-projectsgh-28797
  • Loading branch information
sdeleuze committed Jan 7, 2025
1 parent f514639 commit 0b5d880
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ public final Method getMethod() {
}

@Override
@SuppressWarnings("NullAway") // https://github.com/uber/NullAway/issues/1113
public void setArguments(@Nullable Object... arguments) {
this.arguments = arguments;
}
Expand Down Expand Up @@ -219,7 +218,6 @@ public MethodInvocation invocableClone() {
* @see java.lang.Object#clone()
*/
@Override
@SuppressWarnings("NullAway") // https://github.com/uber/NullAway/issues/1113
public MethodInvocation invocableClone(@Nullable Object... arguments) {
// Force initialization of the user attributes Map,
// for having a shared Map reference in the clone.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ public class SimpleAsyncUncaughtExceptionHandler implements AsyncUncaughtExcepti


@Override
@SuppressWarnings("NullAway") // https://github.com/uber/NullAway/issues/1113
public void handleUncaughtException(Throwable ex, Method method, @Nullable Object... params) {
if (logger.isErrorEnabled()) {
logger.error("Unexpected exception occurred invoking async method: " + method, ex);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ protected Object instantiateWithMethodInjection(RootBeanDefinition bd, @Nullable
}

@Override
@SuppressWarnings("NullAway") // https://github.com/uber/NullAway/issues/1113
public Object instantiate(RootBeanDefinition bd, @Nullable String beanName, BeanFactory owner,
@Nullable Object factoryBean, Method factoryMethod, @Nullable Object... args) {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@ public CacheResolver getCacheResolver() {
}

@Override
@SuppressWarnings("NullAway") // https://github.com/uber/NullAway/issues/1113
public CacheInvocationParameter[] getAllParameters(@Nullable Object... values) {
if (this.allParameterDetails.size() != values.length) {
throw new IllegalStateException("Values mismatch, operation has " +
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ public Object getTarget() {
}

@Override
@SuppressWarnings("NullAway") // https://github.com/uber/NullAway/issues/1113
public Object generate(Object target, Method method, @Nullable Object... params) {
JCacheOperation<?> operation = this.cacheOperationSource.getCacheOperation(method, target.getClass());
if (!(operation instanceof AbstractJCacheKeyOperation)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
public class SimpleKeyGenerator implements KeyGenerator {

@Override
@SuppressWarnings("NullAway") // https://github.com/uber/NullAway/issues/1113
public Object generate(Object target, Method method, @Nullable Object... params) {
return generateKey((KotlinDetector.isSuspendingFunction(method) ?
Arrays.copyOf(params, params.length - 1) : params));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ public DefaultServerResponseBuilder(HttpStatusCode status) {


@Override
@SuppressWarnings("NullAway") // https://github.com/uber/NullAway/issues/1113
public ServerResponse.BodyBuilder header(String headerName, @Nullable String... headerValues) {
Assert.notNull(headerName, "HeaderName must not be null");
for (String headerValue : headerValues) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ public DefaultServerResponseBuilder(HttpStatusCode status) {
}

@Override
@SuppressWarnings("NullAway") // https://github.com/uber/NullAway/issues/1113
public ServerResponse.BodyBuilder header(String headerName, @Nullable String... headerValues) {
Assert.notNull(headerName, "HeaderName must not be null");
for (String headerValue : headerValues) {
Expand Down

0 comments on commit 0b5d880

Please sign in to comment.