Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: install clang-tools-18 #2070

Closed
wants to merge 1 commit into from
Closed

Conversation

avikivity
Copy link
Member

to address the build failure caused by
llvm/llvm-project#59827, and to test the build with C++23, we need to use clang-18. which will be released in March 2023.

Signed-off-by: Kefu Chai kefu.chai@scylladb.com

Closes #2058

[avi: regenerate toolchain]

to address the build failure caused by
llvm/llvm-project#59827, and to test
the build with C++23, we need to use clang-18. which will be
released in March 2023.

Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>

Closes scylladb#2058

[avi: regenerate toolchain]
@avikivity
Copy link
Member Author

@tchaikov tests fail

@tchaikov
Copy link
Contributor

tchaikov commented Feb 1, 2024

@avikivity thank you for redo the image. because clang-scan-deps is packaged in clang-tools-18 package. we need to update circleci to use clang-18 for building C++20 module. i updated #2058 to use docker.io/scylladb/seastar-toolchain:2024-02-01.

@avikivity
Copy link
Member Author

It still fails.

@tchaikov
Copy link
Contributor

tchaikov commented Feb 1, 2024

It still fails.

@avikivity after applying #2071 , the build should be green now .

@tchaikov
Copy link
Contributor

i am closing this change. as 233b48c has landed on master.

@tchaikov tchaikov closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants