Speed up hamming distance calculation and add normalized hamming distance #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grst
requested changes
Jan 19, 2024
There was a problem hiding this comment.
Hi @felixpetschko,
could you please
- fix the merge conflicts
- merge in the latest changes from the
mainbranch - add a testcase for the normalized hamming distance somewhere around here:
|
Superseded by #512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #256
Faster implementation of hamming distance calculation added to HammingDistanceCalculator. Boolean parameter normalize added to HammingDistanceCalculator constructor. If normalize is set to true, the hamming distance values are divided by the sequence length. New metric normalized_hamming added, which uses the HammingDistanceCalculator with normalize set to true.