Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perturbation signature calculation from replicate control cells #695

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Lilly-May
Copy link
Collaborator

PR Checklist

  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

As discussed, we would like to have an alternative to the standard Mixscape perturbation signature calculation. Instead of using the X nearest control cells as a reference, this approach considers all control cells within the same replicate. This change (and the corresponding test) is introduced in this PR. Specifically, I added the parameter ref_selection_mode to the perturbation_signature method, allowing users to select which mode to use: nn for the standard approach or manual for selection via the specified replicate method (I’m open to suggestions for better names!).

@github-actions github-actions bot added the enhancement New feature or request label Jan 10, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 69.56522% with 14 lines in your changes missing coverage. Please review.

Project coverage is 64.92%. Comparing base (218ccb3) to head (0087dcd).

Files with missing lines Patch % Lines
pertpy/tools/_mixscape.py 69.56% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #695      +/-   ##
==========================================
+ Coverage   64.89%   64.92%   +0.02%     
==========================================
  Files          46       46              
  Lines        5994     6004      +10     
==========================================
+ Hits         3890     3898       +8     
- Misses       2104     2106       +2     
Files with missing lines Coverage Δ
pertpy/tools/_mixscape.py 80.27% <69.56%> (-0.02%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants