Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flake8 config #543

Closed
wants to merge 1 commit into from
Closed

fix flake8 config #543

wants to merge 1 commit into from

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Apr 7, 2021

fixes #540

Signed-off-by: zethson lukas.heumos@posteo.net

Signed-off-by: zethson <lukas.heumos@posteo.net>
@Zethson Zethson requested a review from ivirshup April 7, 2021 12:11
@Zethson Zethson changed the title fix #540 fix flake8 config Apr 7, 2021
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #543 (93129d8) into master (14e096e) will decrease coverage by 76.73%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #543       +/-   ##
==========================================
- Coverage   86.25%   9.52%   -76.74%     
==========================================
  Files          25      25               
  Lines        3464    3465        +1     
==========================================
- Hits         2988     330     -2658     
- Misses        476    3135     +2659     
Impacted Files Coverage Δ
anndata/_io/read.py 0.00% <0.00%> (-69.85%) ⬇️
anndata/_io/write.py 0.00% <0.00%> (-73.57%) ⬇️
anndata/_core/views.py 15.65% <100.00%> (-73.83%) ⬇️
anndata/compat/__init__.py 27.64% <100.00%> (-55.29%) ⬇️
anndata/tests/helpers.py 6.31% <100.00%> (-88.43%) ⬇️
anndata/core.py 0.00% <0.00%> (-100.00%) ⬇️
anndata/readwrite.py 0.00% <0.00%> (-100.00%) ⬇️
anndata/_io/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
anndata/_io/h5ad.py 0.00% <0.00%> (-95.33%) ⬇️
anndata/_io/zarr.py 0.00% <0.00%> (-93.84%) ⬇️
... and 17 more

@Zethson
Copy link
Member Author

Zethson commented Apr 8, 2021

Didn't expect this to throw errors.

Issue: AttributeError: partially initialized module 'anndata' has no attribute 'AnnData' (most likely due to a circular import)
I'll have a look.

@ivirshup
Copy link
Member

ivirshup commented Apr 8, 2021

There are going to be a lot of strings used for type annotation because they would otherwise be circular imports. Basically, functions which operate on AnnData objects, which are used in AnnData methods. This may be solved once we can bump minimum python to 3.7 and use from __future__ import annotations, which should be reasonably soon (May-ish?, next major release)

@Zethson
Copy link
Member Author

Zethson commented Apr 8, 2021

Ahh, I see. That's why they were strings before. I was already wondering.

@flying-sheep
Copy link
Member

This is obsolete, we use Ruff now

@flying-sheep flying-sheep deleted the fix/flake8 branch September 8, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake8 config error
3 participants