Remove device renaming and select default device #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device renaming code (/dev/stX -> /dev/nstX) looks fragile and is not portable (Linux is
st, BSD issa, AIX isrmt, etc.). Other tools likemt(1)do not try to redirect commands to the non-rewinding device; if you want to shoot yourself in the foot withmt -f /dev/st0 eodit will do as asked. So I think this utility should just operate with whatever device it is requested by the operator.This change also adopts the behavior of
mt(1)andtar(1)of examining the environment variableTAPEor the value ofDEFTAPEinsys/mtio.hif the device is not explicitly specified.This can partially address #4 and supersede #26.