Fix documentation for running an example. #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also some minor typos
haerdib
added
E0-silent
haerdib
added a commit
that referenced
this pull request
Jan 6, 2023
wohoo fix most finally compiling make clippy happy remove unused comment update comment Fix documentation for running an example (#417) Also some minor typos clean up imports of macors Remove thiserror and use more specific Error names (#419) * small result clean up * lets not overcomplicate * remove thiserror * remove unused errors
haerdib
added a commit
that referenced
this pull request
Jan 9, 2023
wohoo fix most finally compiling make clippy happy remove unused comment update comment Fix documentation for running an example (#417) Also some minor typos clean up imports of macors Remove thiserror and use more specific Error names (#419) * small result clean up * lets not overcomplicate * remove thiserror * remove unused errors fix build Bump tokio from 1.23.0 to 1.23.1 (#427) Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.23.0 to 1.23.1. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.23.0...tokio-1.23.1) --- updated-dependencies: - dependency-name: tokio dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
haerdib
added a commit
that referenced
this pull request
Jan 9, 2023
wohoo fix most finally compiling make clippy happy remove unused comment update comment Fix documentation for running an example (#417) Also some minor typos clean up imports of macors Remove thiserror and use more specific Error names (#419) * small result clean up * lets not overcomplicate * remove thiserror * remove unused errors fix build Bump tokio from 1.23.0 to 1.23.1 (#427) Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.23.0 to 1.23.1. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.23.0...tokio-1.23.1) --- updated-dependencies: - dependency-name: tokio dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
haerdib
added a commit
that referenced
this pull request
Jan 11, 2023
wohoo fix most finally compiling make clippy happy remove unused comment update comment Fix documentation for running an example (#417) Also some minor typos clean up imports of macors Remove thiserror and use more specific Error names (#419) * small result clean up * lets not overcomplicate * remove thiserror * remove unused errors fix build Bump tokio from 1.23.0 to 1.23.1 (#427) Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.23.0 to 1.23.1. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.23.0...tokio-1.23.1) --- updated-dependencies: - dependency-name: tokio dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
haerdib
added a commit
that referenced
this pull request
Jan 11, 2023
* add signer wohoo fix most finally compiling make clippy happy remove unused comment update comment Fix documentation for running an example (#417) Also some minor typos clean up imports of macors Remove thiserror and use more specific Error names (#419) * small result clean up * lets not overcomplicate * remove thiserror * remove unused errors fix build Bump tokio from 1.23.0 to 1.23.1 (#427) Bumps [tokio](https://github.com/tokio-rs/tokio) from 1.23.0 to 1.23.1. - [Release notes](https://github.com/tokio-rs/tokio/releases) - [Commits](tokio-rs/tokio@tokio-1.23.0...tokio-1.23.1) --- updated-dependencies: - dependency-name: tokio dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * redo rebase errors * define new type for <.. as Trait> * remove doubl into and comments * fix rebase errors * fix comments Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mostly wanted to fix the
cargo runcommand for the examples, but I also fixed some minor typos along the way