-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump substrate to polkadot-v0.9.19 #228
Conversation
Add Transactional Error Module specific error value of ModuleError has changed
@@ -121,7 +121,7 @@ impl RuntimeError { | |||
error, | |||
message: _, | |||
}) => { | |||
let error = metadata.error(index, error)?; | |||
let error = metadata.error(index, error[0])?; | |||
Ok(Self::Module(PalletError { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ModuleError has changed https://github.com/paritytech/substrate/blob/580ebae17fa30082604f1c9720f6f4a1cfe95b50/primitives/runtime/src/lib.rs#L476
But it seems that 0 value of error corresponds to the previous index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For documentation purpose, relevant PR: paritytech/substrate#10242
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only one uncertainity: As the substrate-api-client is used by others as well, should we merge the polkadot branch into the master? Or leave it as a branch?
@clangenb what's your opinion?
@echevrier can you rename the branhc (or create a new one, doesn't matter for me) to polkadot-v0.9.19 ? We should keep the naming consistent with substrate
@@ -121,7 +121,7 @@ impl RuntimeError { | |||
error, | |||
message: _, | |||
}) => { | |||
let error = metadata.error(index, error)?; | |||
let error = metadata.error(index, error[0])?; | |||
Ok(Self::Module(PalletError { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For documentation purpose, relevant PR: paritytech/substrate#10242
Changes because of substrate: