wip. zktrie part2: add zktrie; allow switch trie type by config; storage witness generator #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make emptyRoot applicable on both tries * make smt trace output just work Co-authored-by: Ho Vei <noelwei@gmail.com>
|
Move comment here |
mask-pp
reviewed
May 18, 2022
mask-pp
reviewed
May 19, 2022
| "difficulty": "0x1", | ||
| "mixHash": "0x0000000000000000000000000000000000000000000000000000000000000000", | ||
| "coinbase": "0x0000000000000000000000000000000000000000", | ||
| "alloc": { |
There was a problem hiding this comment.
It might be better to use existing account, or we need to provide private key files for those additional accounts.
mask-pp
reviewed
May 19, 2022
| for _, v := range db.rawDirties { | ||
| batch.Put(v.K, v.V) | ||
| } | ||
| for k := range db.rawDirties { |
There was a problem hiding this comment.
not completely clear where should we use make(KvMap) here. Do you mean the db.rawDirties?
| @@ -70,6 +70,10 @@ var ( | |||
| type Database struct { | |||
| diskdb ethdb.KeyValueStore // Persistent storage for matured trie nodes | |||
|
|
|||
| // zktrie related stuff | |||
| Zktrie bool | |||
There was a problem hiding this comment.
It is used in stateDb for detouring some action when chain config has enabled zktrie
lispc
changed the title
lispc
changed the title
lispc
changed the title
lispc
changed the title
lispc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated 2022.05.19(zzhang): I prefer split the zktrie and new storage proof mechanism. So there will be three PR finally
(1) change storage proof from step-wise to block-wise #102
(2) zktrie
(3) zktrie proof (the last 600 lines)
========= OLD CONTENTS =====
This work has finished the first part of a better PR for zktrie: inducing zktrie as an alternative storage layer and providing a more effective, unitify logging scheme for the L2 trace.
There is some breaking change for the trace output comparing to current zktrie work branch:
All the "proof" parts are purged from "extraData" field
The tracing for "after" status of SSTORE opcode is removed, and so "CaptureStateAfter" is of no use now
I think these changes has no affection on the trace handling of roller because no module would refer the proof part except for the mpt-circuit