feat(bridge): ens support in custom recipient input #1341
Merged
+177
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
✅ Deploy Preview for scroll-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yqrashawn
force-pushed
the
custome-recipient-ens-support
branch
from
7a84b2b
to
cc68dee
Compare
|
|
yqrashawn
force-pushed
the
custome-recipient-ens-support
branch
2 times, most recently
from
fc8d736
to
ddfa18b
Compare
thanks for the review, this is fixed now |
yqrashawn
force-pushed
the
custome-recipient-ens-support
branch
from
ddfa18b
to
e4efed4
Compare
When "Customise recipient" is turned off, the error message should be removed. @yqrashawn |
yqrashawn
force-pushed
the
custome-recipient-ens-support
branch
from
e4efed4
to
c817ba4
Compare
Signed-off-by: yqrashawn <namy.19@gmail.com>
yqrashawn
force-pushed
the
custome-recipient-ens-support
branch
from
c817ba4
to
63d5f9a
Compare
|
thanks for the review @zzq0826 |
Holybasil
approved these changes
Nov 5, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
resolve GEN-1323
comment: Summarise the problem and how the pull request solves it
user can now use ens name in custom recipient input
Checklist
/docs