Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hooks #290

Merged
merged 5 commits into from
Sep 10, 2020
Merged

Use hooks #290

merged 5 commits into from
Sep 10, 2020

Conversation

scriptex
Copy link
Owner

@scriptex scriptex commented Sep 4, 2020

This PR implements hooks in the complex donut and also fixes it's unmount lifecycle hook which calls nonexistent function.

@scriptex scriptex added bug Something isn't working enhancement New feature or request labels Sep 4, 2020
@scriptex scriptex self-assigned this Sep 4, 2020
This was linked to issues Sep 4, 2020
Use hooks #287
Closed
Wrong willUnmount #286
Closed
scriptex
scriptex commented Sep 5, 2020
View reviewed changes
Copy link
Owner Author

@scriptex scriptex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove dist from git
  2. Add props change in demo

@scriptex scriptex merged commit cc03c13 into master Sep 10, 2020
@scriptex scriptex deleted the feature/hooks branch September 10, 2020 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scriptex scriptex

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use hooks Wrong willUnmount
1 participant
@scriptex