Adding social links and redirects to About section content #328
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes well. Feel free to address the points below yourself in further commits if you realize that actions are needed :) Maintainer Checklist
|
|
Hey @andrewtavis, just wanted to make sure you saw this PR 😅 |
|
I did, @SaurabhJamadagni! Sorry :( I’ll get to it tomorrow morning at the latest :) Call for the activist backend is tomorrow at 13:00 UTC :) You can see the details in the dev channel on Matrix 🙃 |
|
Oh cool no problem 👍 Sorry @andrewtavis, I don't think I will be able to make it to the call tomorrow. I have a family dinner. I'll join the meeting directly in case of any cancellations on the dinner front. |
|
Sounds good, @SaurabhJamadagni! Have a nice dinner! |
| if MFMailComposeViewController.canSendMail() { | ||
| let mailComposeViewController = MFMailComposeViewController() | ||
| mailComposeViewController.mailComposeDelegate = self | ||
| mailComposeViewController.setToRecipients(["scribe.language@gmail.com"]) |
There was a problem hiding this comment.
Hey! 👋
I noticed that it's possible to set the subject line and the message body as well like the recipients here. I'm thinking that the message body is likely fine staying blank, but would it make sense perhaps to have some default set for the subject line? Just more so thinking in terms of what would be easier or expected from the user perspective.
There was a problem hiding this comment.
Hey Will!
I did consider that. But we have separate sections for almost all the reasons a user might want to approach us. For example, to report a bug there is a section and to rate and share feedback there's the rating section. So writing an email seemed like a very ambiguous use case. That's why I didn't add a subject line in case the user wished to write an email for a completely different reason. Could be a complaint but could also be an email of appreciation 😅
There was a problem hiding this comment.
I agree that the use case for emails is going to ambiguous 🤔 I just checked and we're still at a grand total of 0 emails 😄 With that being said, maybe something inviting to the user? Hey Scribe!, for instance?
There was a problem hiding this comment.
Sounds good @andrewtavis! We can do that. Just a tiny problem. I kind of committed my changes for the privacy policy issue (#317) to the branch already. So if I push it now that'll be added to the PR too. So would it be okay if I made this change in the next PR? I am so sorry! 🙈
There was a problem hiding this comment.
100% ok, @SaurabhJamadagni 😊 No need to apologize :)
There was a problem hiding this comment.
Sorry again for the wait, @SaurabhJamadagni! Really well done :) This here menu really is taking shape! I'll get those designs for the info tooltip up shortly so they're ready for the work that's coming up 😊
|
No problem on the wait @andrewtavis. Thank you so much! 😄 |
Contributor checklist
Description
PR adds interactivity to cells in the About section table view that redirect to a link or call for action.
Related issue