#181 add Twitter and Reddit buttons to repo readme #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaurabhJamadagni
approved these changes
Oct 22, 2022
There was a problem hiding this comment.
Works great @andrewtavis! I pushed it to my fork and the buttons look great on the README. Perfect location and the post it creates when clicked looks good too!
|
Thanks, @SaurabhJamadagni! Will bring this in now then :) Hope you're having a nice weekend! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's my attempt at making them work, @SaurabhJamadagni 😊 I chose to just add them to the end of the top shields as we're just trying to prompt people when they land there to consider using them or sharing in their own way. I don't think that we need to put them on their own line :)
The twitter button has text with
#languagelearningand the reddit button just has the URL and a general title, which I thought made sense as we're not sure where they'll post it. Your input is more than welcome!