Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double space period shortcut unintended trigger #55

Closed
andrewtavis opened this issue Nov 30, 2021 · 0 comments · Fixed by #65
Closed

Double space period shortcut unintended trigger #55

andrewtavis opened this issue Nov 30, 2021 · 0 comments · Fixed by #65
Assignees
@andrewtavis
Labels
-priority- High priority bug Something isn't working help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Nov 30, 2021 •
edited
Loading

The behavior of the double space period shortcut is buggy in the MVP release. It seems to be being triggered after one space at times, and in that case the prior character in the document proxy is deleted.

A simple way to reproduce this is to type keys close to the space bar followed by space. The bug also exists where caps lock is triggered when another key is pressed quickly before shift, so there apparently needs to be logic added to prevent these when other keys are pressed before the trigger key.
@andrewtavis andrewtavis added bug Something isn't working help wanted Extra attention is needed -priority- High priority labels Nov 30, 2021
andrewtavis added a commit that referenced this issue Dec 2, 2021
@andrewtavis
#55 Fix bug where double space period would be triggered unexpectedly…
a27635b 
… and add punction shortcuts to Spanish keyboard
andrewtavis added a commit that referenced this issue Dec 2, 2021
@andrewtavis
Merge pull request #65 from scribe-org/double-space-period-bug
d4633ba 
#55 Fix bug where double space period would be triggered unexpectedly
@andrewtavis andrewtavis linked a pull request Dec 2, 2021 that will close this issue
#55 Fix bug where double space period would be triggered unexpectedly #65
Merged
@andrewtavis andrewtavis self-assigned this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewtavis andrewtavis

Labels
-priority- High priority bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#55 Fix bug where double space period would be triggered unexpectedly scribe-org/Scribe-iOS
1 participant
@andrewtavis