Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size keys on expanded iPad keyboards #362

Closed
2 tasks done
andrewtavis opened this issue Sep 18, 2023 · 11 comments
Closed
2 tasks done

Size keys on expanded iPad keyboards #362

andrewtavis opened this issue Sep 18, 2023 · 11 comments
Assignees
Labels
design Relates to UX/UI designs good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

This issue is the second half of #352 where the expanded keyboard layouts for iPads are assigned and are able to be switched to with the 123?! key. Within this issue we'll go through and create conditionals to style the keyboards based on the new keys such as the tab key and others :)

Note that we'll be going for a generic layout for all keyboards. In the system keyboard sometimes there are differences like the return key being L shaped and other elements, but this will not be done at this time. Goal for this is to include this in the 3.0.0 release 🚀

Contribution

Happy to support someone with interest in working on this!

@andrewtavis andrewtavis added good first issue Good for newcomers help wanted Extra attention is needed design Relates to UX/UI designs labels Sep 18, 2023
@andrewtavis
Copy link
Member Author

CC @henrikth93 who's working on #352 :)

@henrikth93
Copy link
Member

I can take this issue

@andrewtavis
Copy link
Member Author

Thank you, @henrikth93! Assigning now 🚀🚀

@andrewtavis
Copy link
Member Author

Hey there @henrikth93 👋 Here are the layouts that we're looking for in one place that I'm bringing over from #33:

Danish (#133)

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 21 57 51

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 15 28

English (#7)

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 00 15

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 16 16

French

Canada

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 01 04

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 16 50

France

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 01 31

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 17 20

German

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 21 51 44

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 17 52

Hebrew (#134)

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 02 22

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 18 24

Italian

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 02 56

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 19 19

Norwegian (Bokmål, #135)

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 03 25

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 19 50

Portuguese

Brazil

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 21 04

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 20 20

Portugal

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 04 56

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 21 37

Russian

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 05 24

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 22 03

Spanish

Mexico

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 23 11

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 22 32

Spain

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 07 07

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 23 39

Swedish

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 07 40

Simulator Screenshot - iPad Pro (12 9-inch) (4th generation) - 2023-07-12 at 22 24 06

@andrewtavis
Copy link
Member Author

Do you want to work on this issue keyboard by keyboard? I don't think that we need separate issues for each one, but we can do separate pull requests 😊

@henrikth93
Copy link
Member

Do you want to work on this issue keyboard by keyboard? I don't think that we need separate issues for each one, but we can do separate pull requests 😊

Separate PRs sounds good!

@andrewtavis
Copy link
Member Author

In addition to this, we need to make sure that the number keys row is has more height :)

@andrewtavis
Copy link
Member Author

List of keyboards:

  • English
  • French
  • German
  • Italian
  • Portuguese
  • Russian
  • Spanish
  • Swedish

Let's make sure to add in a right shift key for the symbol keys for each keyboard so that that row has appropriate spacing. Another minor change is that the tab key should be a bit more narrow so that the key spacing on that row is consistent with the rest of the keyboard :)

@henrikth93
Copy link
Member

List of keyboards:

  • English
  • French
  • German
  • Italian
  • Portuguese
  • Russian
  • Spanish
  • Swedish

Let's make sure to add in a right shift key for the symbol keys for each keyboard so that that row has appropriate spacing. Another minor change is that the tab key should be a bit more narrow so that the key spacing on that row is consistent with the rest of the keyboard :)

To me, the German version also looks good.

@andrewtavis
Copy link
Member Author

I'll close out German after we have the next PR that also adds in the rest of the minor changes below:

Let's make sure to add in a right shift key for the symbol keys for each keyboard so that that row has appropriate spacing. Another minor change is that the tab key should be a bit more narrow so that the key spacing on that row is consistent with the rest of the keyboard :)

Really looking forward to getting this all done, @henrikth93 😊 Let me know if you need any support!

andrewtavis added a commit to henrikth93/Scribe-iOS that referenced this issue Mar 31, 2024
andrewtavis added a commit that referenced this issue Mar 31, 2024
…-keys

#362 Changed the expanded keyboard for more languages
@andrewtavis
Copy link
Member Author

andrewtavis commented Mar 31, 2024

Closed via #362! 🥳 So great that we have this done now! 🚀 Thanks @henrikth93!!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Scribe Board Mar 31, 2024
SaurabhJamadagni pushed a commit to marekviktor/Scribe-iOS that referenced this issue Apr 18, 2024
SaurabhJamadagni pushed a commit to marekviktor/Scribe-iOS that referenced this issue Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Relates to UX/UI designs good first issue Good for newcomers help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

2 participants