Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color refinement for light and dark modes #31

Closed
andrewtavis opened this issue Nov 23, 2021 · 2 comments
Closed

Color refinement for light and dark modes #31

andrewtavis opened this issue Nov 23, 2021 · 2 comments
Assignees
Labels
design Relates to UX/UI designs good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Nov 23, 2021

This issue is to refine colors in both light and dark mode implementations. ColorVariables.swift has all the coloration variables for Scribe keyboards, with these values being selected to work for an MVP release. There are surely better versions of many of these colors. The key and background colors could look more like the system keyboards, and annotation colors could look more consistent and show up better.

Adding further colors would be an extra step in this issue, as there is a likelihood that users will eventually be able to select which colors they want to use for annotations. In that case it would be best to have pre-set values for generic colors that they can choose from that will show up well on the backgrounds.

  • Ideas on Scribe brand colors would also be appreciated if contributors are interested, which would be linked to Scribe key design  #24
@andrewtavis andrewtavis added good first issue Good for newcomers help wanted Extra attention is needed design Relates to UX/UI designs labels Nov 23, 2021
@andrewtavis
Copy link
Member Author

andrewtavis commented Jan 8, 2022

The pronouns and verb forms shown during Conjugate in dark mode are currently a bit hard to see. The ratio between the key color and these annotations, the same color as the command bar, specifically needs work.

@andrewtavis andrewtavis mentioned this issue Jan 25, 2022
26 tasks
@andrewtavis
Copy link
Member Author

Closed via 6449021 for the design sprint in #112. Color palettes have now been updated, with readability now being dramatically better.

@andrewtavis andrewtavis self-assigned this Apr 7, 2023
andrewtavis added a commit that referenced this issue Aug 2, 2024
5bd9672 Convert sv only one language message in .xcstrings
ba577bd Merge pull request #32 from weblate/weblate-scribe-scribe-i18n
1a4cd28 Translated using Weblate (Swedish)
9370443 Merge pull request #31 from Jag-Marcel/xcode-script-fix
7c406b6 Change to xcstrings conversion

git-subtree-dir: Scribe/i18n
git-subtree-split: 5bd96728377b0ce2cf11bc48d5966627d016b491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Relates to UX/UI designs good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant