Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch URL in App Screen to iOS Repo #178

Closed
2 tasks done
andrewtavis opened this issue Jul 21, 2022 · 6 comments
Closed
2 tasks done

Switch URL in App Screen to iOS Repo #178

andrewtavis opened this issue Jul 21, 2022 · 6 comments
Assignees
Labels
-next release- Included in the next release feature New feature or request good first issue Good for newcomers

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Jul 21, 2022

Terms

Description

This is a very simple issue. Currently the link to GitHub in the app screen goes to the organization, but instead it should go to this repository. This change would happen in ViewController.swift and ENAppText.swift.

Reason for this is that most people who click the link will be mostly curious about Scribe-iOS.

Contribution

I'd be happy to get to this if no one else has interest :)

@andrewtavis andrewtavis added feature New feature or request good first issue Good for newcomers -next release- Included in the next release labels Jul 21, 2022
@andrewtavis
Copy link
Member Author

@SaurabhJamadagni, messaging you in here so that I can hopefully assign you. Wasn’t letting me select you, but maybe if you’re linked in the chat it’ll work :)

@andrewtavis
Copy link
Member Author

Hmmmmm, still not. Could you confirm in here that you want to work on this, and I’ll assign it? Also, just checking, does this change make sense to you?

@SaurabhJamadagni
Copy link
Collaborator

Could you confirm in here that you want to work on this, and I’ll assign it? Also, just checking, does this change make sense to you?

Yes, @andrewtavis I would like to work on this one. It makes sense to route the users coming from the iOS app to the iOS repo and respectively for the android counterpart :)

@andrewtavis
Copy link
Member Author

Thanks for your willingness to help, and further for the feedback that we should do this 😊

@andrewtavis
Copy link
Member Author

Thank you for the PR, @SaurabhJamadagni! I'm thinking post e0a6b85 above that you're welcome to edit the CHANGELOG.md to describe your work in future PRs :) Obviously I'm happy to do it myself, so only if you'd like to 😊

@SaurabhJamadagni
Copy link
Collaborator

Thank you for the PR, @SaurabhJamadagni! I'm thinking post e0a6b85 above that you're welcome to edit the CHANGELOG.md to describe your work in future PRs :) Obviously I'm happy to do it myself, so only if you'd like to 😊

That is very gracious of you @andrewtavis, thank you very much 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-next release- Included in the next release feature New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants