Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coloration of nouns in autocomplete and suggest #164

Closed
2 tasks done
andrewtavis opened this issue Apr 19, 2022 · 7 comments
Closed
2 tasks done

Coloration of nouns in autocomplete and suggest #164

andrewtavis opened this issue Apr 19, 2022 · 7 comments
Assignees
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Apr 19, 2022

Terms

Description

As work commences on #3, a secondary goal will be to color the nouns within the suggestions and completions so that the user can get continual practice of noun genders. The general idea now is that after pressing space would be the time where the annotation block is shown with the gender(to assure that color blind users have this functionality), and at any other time the word would simply be colored.

Contribution

I’ll work on this as I work on #188 and #194 :)

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed labels Apr 19, 2022
@andrewtavis andrewtavis added the blocked Another issue is blocking label Jun 28, 2022
@andrewtavis
Copy link
Member Author

This feature will be unblocked when #188 and #194 are implemented. I doesn't need to be in the next release, but could be included in a future one :)

@andrewtavis
Copy link
Member Author

Another possibility for this is that rather than coloring the words, we could put a small marker under them that would be colored for the given gender. This would allow words with more than one gender to be displayed as the marker could be split, and would keep some consistency in the text colors for the autocomplete and autosuggest words.

The following shows what this could look like with thin rectangles (Leben in German is neutral and is its own plural):

Autocomplete

@andrewtavis
Copy link
Member Author

Note that this issue is blocked by the following issues:

@andrewtavis
Copy link
Member Author

Benefits to this would also be that someone could see that they'd used the wrong article before they finished typing the noun and could also see that a word is plural and more easily recognize it as the word they want.

@andrewtavis andrewtavis removed the blocked Another issue is blocking label Apr 20, 2023
@andrewtavis
Copy link
Member Author

Removed blocked from this issue as general feedback makes it sound like this would be a viable default feature that we wouldn’t need an option to disable in order to implement.

@andrewtavis
Copy link
Member Author

I think that it makes sense to work on this issue after #290 is finished though :)

@andrewtavis
Copy link
Member Author

Closed via bb1c265 😊😊 Really cool addition :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

1 participant