Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scribe key icon sometimes not changing with the color mode #116

Closed
2 tasks done
andrewtavis opened this issue Feb 2, 2022 · 2 comments
Closed
2 tasks done

Scribe key icon sometimes not changing with the color mode #116

andrewtavis opened this issue Feb 2, 2022 · 2 comments
Assignees
@andrewtavis
Labels
-priority- High priority bug Something isn't working good first issue Good for newcomers

Comments

@andrewtavis
Copy link
Member

Terms

Behavior

#106 seems to be fixed except that the Scribe key icon is sometimes the wrong one. Readability wise this does not negatively affect the experience, but is unintended behavior.

Device type

iPhone and iPad

iOS version

I assume this is happening for all versions.
@andrewtavis andrewtavis added the bug Something isn't working label Feb 2, 2022
@andrewtavis andrewtavis self-assigned this Feb 2, 2022
@andrewtavis andrewtavis added the good first issue Good for newcomers label Feb 2, 2022
@andrewtavis
Copy link
Member Author

To fix this we just need to assign the Scribe key based within checkDarkModeSetColors in ColorVariables.swift, not within a function that will be called during loadKeys.

@andrewtavis andrewtavis added the -priority- High priority label Feb 2, 2022
andrewtavis added a commit that referenced this issue Feb 2, 2022
@andrewtavis
#116 share DeviceType and update Scribe icon in dark mode check
e846dca
@andrewtavis
Copy link
Member Author

Closed in e846dca. The Scribe key is now updated within checkDarkModeSetColors in ColorVariables.swift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewtavis andrewtavis

Labels
-priority- High priority bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewtavis