-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand and Refactor Latin Verb Query to Focus on Present Tense Forms #495
base: main
Are you sure you want to change the base?
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist |
Can you check out the workflow errors and make the needed fixes, @KesharwaniArpita? |
Hey @KesharwaniArpita 👋 Checking in here on this :) Do you think you'll have time to address the errors from the query check workflows? |
Hi @andrewtavis , I'll surely do this. I apologize, I got busy with my end semester lab work and missed the mail. But I'll surely get back to it. Thanks for checking! |
Hi @andrewtavis, I have resolved the errors. I think we are good to go! Thank you :) |
Ok @KesharwaniArpita :) So there was a minor bug in the forms check workflow that was causing it to not run. There are still many errors in the queries, which you can see here and also run locally with Can you pull down the most recent changes and go through the needed changes as shown in the workflow errors? Big thing here is maybe it makes sense to really restrict this as much as we can such that each individual query just has four forms. Might make sense to do it that way as it really is getting to be tough to navigate the queries. So steps from here:
Let me know if you have any questions on the above! |
Sure @andrewtavis . I'll work on it. Thanks for letting me know. |
Contributor checklist
pytest
command as directed in the testing section of the contributing guideDescription
This PR expands and refactors the existing SPARQL query to focus solely on Present Tense verb forms(till now) for Latin (Q397) verbs. The changes made include:
VALUES
block.OPTIONAL
blocks to align with this restriction, ensuring they cover Subjunctive, Imperative, and Indicative for different persons (First, Second, Third; Singular and Plural).Testing:
Future Work:
Past Tense: A similar refactor can be done to retrieve past tense verb forms(available on wikidata). These can be added using a
VALUES
block that filters for relevant grammatical features such as:Future Tense: The query can be extended to retrieve future tense forms by adding future-specific grammatical features:
Both Past and Future tense forms can follow the same pattern as this Present Tense query, with additional
VALUES
blocks or separate queries focused on those tenses.Impact:
The refactor improves the clarity and performance of the current query by focusing on a single tense while maintaining flexibility for future enhancements to cover other tenses.
Related issue