fix: Do not interpret special characters (e.g ", `) from context vari…

…ables
scribd · Apr 21, 2023 · d9c6e2d · d9c6e2d
1 parent 687329f
commit d9c6e2d
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -28,6 +28,19 @@ jobs:
           token: ${{ secrets.SCRIBD_SLACK_GENERIC_TOKEN_PUBLIC }}
           channel: test-release-notification
           message: <https://scribd.com|Custom message>
+  test-custom-message-with-special-characters:
+    runs-on: ubuntu-22.04
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+        with:
+          token: ${{ secrets.GITHUB_TOKEN }}
+      - name: Run action
+        uses: ./
+        with:
+          token: ${{ secrets.SCRIBD_SLACK_GENERIC_TOKEN_PUBLIC }}
+          channel: test-release-notification
+          message: <https://scribd.com|Special characters + "quotes" + `backtick`>
   test-overwrite-repository:
     runs-on: ubuntu-22.04
     steps:

diff --git a/action.yml b/action.yml
@@ -35,11 +35,11 @@ runs:
           echo "color=warning" >> $GITHUB_OUTPUT
         fi
 
-        if [ ! -z "${{ inputs.message }}" ]; then 
-          message="${{ inputs.message }}"
-        elif [ ! -z "${{ github.event.head_commit.message }}" ]; then 
+        if [ ! -z '${{ inputs.message }}' ]; then 
+          message='${{ inputs.message }}'
+        elif [ ! -z '${{ github.event.head_commit.message }}' ]; then 
           # get commit message from `push` trigger
-          commit_message=$(echo "${{ github.event.head_commit.message }}" | head -n 1)
+          commit_message=$(echo '${{ github.event.head_commit.message }}' | head -n 1)
           message="<https://github.com/${{ inputs.repository }}/commit/${{ github.sha }}|$commit_message>"
         elif git rev-parse --is-inside-git-dir > /dev/null 2>&1; then  
           # get commit message from the current git directory to support `workflow_dispatch` trigger
@@ -91,7 +91,7 @@ runs:
                   },
                   {
                     "title": "Commit Message",
-                    "value": "${{ steps.fields.outputs.message }}",
+                    "value": ${{ toJSON(steps.fields.outputs.message) }},
                     "short": false
                   }
                 ]