fix(): when using s3, parse stream output to buffer for html files #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
increase token timeout to 13hrs map yidf/state to txt extension
adong
reviewed
May 19, 2021
| @@ -47,7 +47,7 @@ async function init() { | |||
|
|
|||
| return logger.info('Server running at %s', server.info.uri); | |||
| } catch (err) { | |||
| logger.error(err); | |||
| logger.error(err.toString()); | |||
There was a problem hiding this comment.
How about JSON.stringify, does JSON.stringify capture many info nosies?
There was a problem hiding this comment.
this is a bug with logger we use winston This is what we should do long term winstonjs/winston#1338 (comment)
adong
reviewed
May 19, 2021
| @@ -31,6 +32,10 @@ class AwsClient { | |||
| } | |||
| }; | |||
|
|
|||
| if (config.sessionToken) { | |||
There was a problem hiding this comment.
is this added for local debugging only?
There was a problem hiding this comment.
Yes, any setup with a federated login, not sure if there is a scope to use this to move away from access key based login.
There was a problem hiding this comment.
Added this, to remove IAM user dependency screwdriver-cd/screwdriver#2454
pritamstyz4ever
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Objective
References
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.