Skip to content

Use constants for movement fatigue #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use constants for movement fatigue #133

wants to merge 1 commit into from

Conversation

jollygreenlaser
Copy link

Requires: screeps/common#15

Giving this constants makes it easier:

  1. For seasons or mods to change them
  2. For players to calculate fatigue without magic numbers or creating their own consts

Hopefully I didn't miss any spots.

@jollygreenlaser jollygreenlaser mentioned this pull request Nov 23, 2021
Open
sparr
sparr approved these changes Jun 17, 2023
View reviewed changes
Copy link
Contributor

@sparr sparr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for eliminating magic numbers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@sparr sparr sparr approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jollygreenlaser @sparr