Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed EconRequest name to EconInfo and moved it out of requests object #8

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Robalian
Copy link

@Robalian Robalian commented Dec 30, 2023

Also fixed jsdoc for PlayerRequest.
Also added optional "timeout" property to all requests.

@Robalian Robalian changed the title WIP: Request leak fix. Request leak fix. Dec 30, 2023
@Robalian Robalian changed the title Request leak fix. Changed EconRequest name to EconInfo and moved it out of requests object Dec 31, 2023
@CarsonBurke
Copy link
Member

I think this makes a lot of sense. Sorry, but can you please submit this to the development branch instead?

@CarsonBurke CarsonBurke self-assigned this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants