Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dragging out of flyout when workspace is zoomed #201

Conversation

rachel-fenichel
Copy link
Collaborator

Fixes #150

*/
Blockly.Flyout.placeNewBlock_ = function(originBlock, workspace,
flyout) {
var svgRootOld = originBlock.getSvgRoot();

This comment was marked as abuse.

@tmickel
Copy link
Contributor

tmickel commented Apr 12, 2016

@rachel-fenichel
This looks like it's working to me. I still don't really understand the overall logic, but I understand how you mirrored the transforms for horizontal. Happy to have this merged even if it's not straightforward...

@rachel-fenichel
Copy link
Collaborator Author

I don't fully understand either, though I suspect I'm going to have to as I try to fix some other problems with this (things like how zoomToFit works). I did get a sanity check from neil about this.

@rachel-fenichel rachel-fenichel merged commit c9d0559 into scratchfoundation:develop Apr 12, 2016
@rachel-fenichel rachel-fenichel deleted the bugfix/horizontal_toolbox_zoom branch April 12, 2016 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants