Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size of blocks with boolean-type edge shape sometimes needs to be extended #376

Closed
tmickel opened this issue Jun 8, 2016 · 4 comments
Closed

Size of blocks with boolean-type edge shape sometimes needs to be extended #376

tmickel opened this issue Jun 8, 2016 · 4 comments
Assignees
@tmickel
Labels
bug design
Milestone
August 18

Comments

@tmickel
Copy link
Contributor

tmickel commented Jun 8, 2016

This is a two-part problem:

  1. The internal padding for boolean-edge shapes is too small per spec. This should be a simple adjustment.
  2. Sometimes really ugly things happen with blocks:
    screen shot 2016-06-08 at 12 20 42 pm

This is also a problem in Scratch 2.0, but doesn't become much of a problem until there are many blocks, because the padding is much smaller:
screen shot 2016-06-08 at 12 22 28 pm

To fix problem #2, we could add more space horizontally somehow...
@tmickel tmickel added the design label Jun 8, 2016
@thisandagain thisandagain added this to the Backlog milestone Jun 14, 2016
@thisandagain thisandagain modified the milestones: July 21, Backlog Jun 24, 2016
@tmickel
Copy link
Contributor Author

tmickel commented Jul 6, 2016

@carljbowman Any further thoughts of what you want to do with this? It looks a little better now:
screen shot 2016-07-06 at 4 51 37 pm

@tmickel
Copy link
Contributor Author

tmickel commented Jul 6, 2016

(with rounded corners)

@luxaritas
Copy link

Would it be possible to add more padding on the left and right still, regardless of the issue with overflow of the reporter itself? Seems really cramped to me, without any space to the side of the input.

tmickel pushed a commit to tmickel/scratch-blocks that referenced this issue Jul 12, 2016
@NeilFraser
Merge pull request scratchfoundation#376 from google/revert-371-proxy
493fa91 
Revert "proxy option for build.py"
@tmickel tmickel modified the milestones: August 18, July 21 Jul 25, 2016
@tmickel tmickel assigned tmickel and unassigned carljbowman Jul 25, 2016
tmickel added a commit to tmickel/scratch-blocks that referenced this issue Jul 26, 2016
@tmickel
Output padding to spec, fixing scratchfoundation#376
4b21bef
tmickel added a commit that referenced this issue Jul 26, 2016
@tmickel
Various tweaks to shape and size (#544)
3f3862a 
* Align text by consistent baseline

* Helvetica

* CORNER_RADIUS in grid units

* Separate MIN_BLOCK_X for reporters from single-field shadows

* Update Blockly.BlockSvg.FIELD_WIDTH

* Remove padding on htmlInput

* Also apply border-radius to htmlInput_ to avoid weird edge effect in Chrome

* Update MIN_BLOCK_X to spec

* Fix horizontal sizing of blocks to include right corner.

* Add EDITABLE_FIELD_PADDING

This gives extra width to editable text fields.

* Add correct height for reporters

* Fix INLINE_PADDING_Y and reporter sizing to spec

* Remove unused case for input.renderWidth

* Instrument vertical rendering with right/left row padding.

* Revert renderWidth change

* Fix calculation of input shape widths

* Output padding to spec, fixing #376

* Update horizontal FIELD_TOP_PADDING for new dominant baseline

* Update padding language to be LTR/RTL neutral

* Remove broken RTL SEP_SPACE_X from input shape drawing
@tmickel
Copy link
Contributor Author

tmickel commented Jul 26, 2016

Resolved :)

@tmickel tmickel closed this as completed Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmickel tmickel

Labels
bug design
Projects
None yet
Milestone
August 18
Development

No branches or pull requests
4 participants
@tmickel @thisandagain @carljbowman @luxaritas