Testing - Automate and update jsunit test suite #12
Comments
|
@thisandagain Do you think we're ready to have eslint run with Travis? I'd be pretty happy if that was working, even if it doesn't yet pass the linter. Seeing the tests failing would be a good motivator to fix it up... :) Don't know how to set it up (or if I can), though. |
|
@tmickel Agreed. That sounds great. You are an admin so you should be able to enable Travis for this repo from your https://travis-ci.org settings page. |
|
Ok, I did that! Not sure how to do jsunit but I'll look into that also for a bit |
|
Hmmm, given the weirdness of the closure jsunit setup and the small number of tests, I wonder if it might even be worth it just to rewrite the tests using our normal test framework... |
|
We're also looking into Travis on the Blockly side. It's not moving very fast, but we'll let you know if we get anything working there. |
…s, + menu bar (scratchfoundation#83) * Covers parts of these issues: GUI layout panes (scratchfoundation#69), sprite libraries (scratchfoundation#12), import buttons (scratchfoundation#64), menu bar (scratchfoundation#67), and sprite info area (scratchfoundation#53) ~ Refactored layout pane structure by removing `display: flex` from `.box`, by default. Declaring flex instead only where specifically needed. This helped fix layout quirks, and should help us avoid hard to find issues related to nested flex boxes ~ Added descriptive classnames to boxes/containers/wrappers. Moved more padding, margins + layout into these wrappers to help with component reusability. ~ Set up a spacer unit variable inside `gui.css`, to start keeping consistent padding, margins and rounded corners between panes. Used [CSS/PostCSS Modules](https://github.com/css-modules/postcss-modules-values) to avoid SCSS dependency. ~ Refactored inline styles from JSX, into CSS files. 2 reasons: a) prepping for reuse of CSS Module variables. b) Feels easier to debug complex flex layouts when all the styles are in one place vs JS/HTML/CSS syntax mixed together ~ Added menu bar into layout via new component, and sprite info header in sprite selector pane, with stubs for the labels + forms. Sprite items are correctly scrolling, while leaving the header fixed, in Chrome. Mostly working in FFx. Not working in Safari, IE yet. ~ Style pass on library modal ~ Experimenting with a few different transition styles: Logo in menu bar, sprite library items, Add buttons.
* Design pass on libraries to make sprites look more like they do in the SpriteSelector. Fixed scrolling overflow when reaching the bottom * Started a colors variables file * Added a light transform on sprite item hover Related scratchfoundation#12
Test suite will need to be updated to reflect new grammar, blocks, and generators. While doing so, we should automate the
jsunitandjslinttesting via Travis-CI which should help with open source contribution quite a bit.The text was updated successfully, but these errors were encountered: