Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest version of Ubuntu #197

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Use latest version of Ubuntu #197

merged 1 commit into from
Oct 26, 2022

Conversation

Laerte
Copy link
Member

@Laerte Laerte commented Oct 22, 2022

All workflows of Scrapy org runs on ubuntu-latest runner, except for w3lib and tests workflow of scrapyd that's is being handled here

@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Merging #197 (f223d6c) into master (74c9041) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #197   +/-   ##
=======================================
  Coverage   95.96%   95.96%           
=======================================
  Files           6        6           
  Lines         471      471           
  Branches       90       90           
=======================================
  Hits          452      452           
  Misses          9        9           
  Partials       10       10           

@Gallaecio
Copy link
Member

@Laerte
Copy link
Member Author

Laerte commented Oct 23, 2022

@Gallaecio While i understand your point, i think the use case that you mentioned in the comment is more valid if the project rely on external packages/libraries.

In our case we don't rely in any external package/library. So if the python interpreter is successfully installed we should not have any failing behaviour changing our runner.

Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s true. This is a pure Python package without dependencies. Which Ubuntu version we run should have no effect on tests. Thank you!

@wRAR wRAR merged commit 540d7f3 into scrapy:master Oct 26, 2022
@Laerte Laerte deleted the chore/switch-ubuntu-version branch October 26, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants