Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a workaround for an old pathname2url bug #142

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

Gallaecio
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #142 into master will increase coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
+ Coverage   95.43%   95.83%   +0.39%     
==========================================
  Files           7        7              
  Lines         482      480       -2     
  Branches       98       97       -1     
==========================================
  Hits          460      460              
+ Misses         15       14       -1     
+ Partials        7        6       -1
Impacted Files Coverage Δ
w3lib/url.py 99.01% <ø> (+0.96%) ⬆️

@Gallaecio Gallaecio changed the title Remove a workaround for n old pathname2url bug Remove a workaround for an old pathname2url bug Oct 24, 2019
@kmike
Copy link
Member

kmike commented Jun 16, 2022

+1 to merge after resolving merge conflicts!

@Gallaecio Gallaecio merged commit 97ac45b into scrapy:master Jun 16, 2022
@kmike kmike added this to the 2.0.0 milestone Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants