Add more test cases for subclasses using @field #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurnzZ
force-pushed
the
fix-some-use-cases
branch
from
1479cf6 to
c9c1db8
Compare
BurnzZ
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #83 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 17 17
Lines 536 536
=======================================
Hits 535 535
Misses 1 1 |
|
@BurnzZ should we merge or close the PR? |
BurnzZ
changed the title
|
@kmike , I forgot about this, thanks for reminding. I think we could still merge it after reviewing. |
Gallaecio
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding and fixing some use cases before Approach 1 from #77 begins development.