-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new AnyResponse #195
add new AnyResponse #195
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 98.44% 98.46% +0.02%
==========================================
Files 30 31 +1
Lines 1414 1437 +23
==========================================
+ Hits 1392 1415 +23
Misses 22 22
|
I think we need to have docs for this class; I'm not sure it makes sense to deprecate it later. It shouldn't be only about the extraction source, it should be possible to use this dependency without any extraction as well. The logic is the following: if there is BrowserResponse dependency in the plan, BrowserResponse is going to be used; if not, it probably should use HttpResponse. |
Looks good, thanks @BurnzZ! |
A way to address zytedata/zyte-spider-templates#25.
Related PRs:
Not quite sure if we should have a detailed documentation about this class in the tutorials since it may be deprecated in the next few months when Zyte API handles Auto-Configuration (i.e. selecting the best extraction source between HttpResponse and BrowserResponse).EDIT: Added docs.