move some registry functionalities from scrapy-poet #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 6, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
==========================================
- Coverage 99.85% 99.56% -0.30%
==========================================
Files 22 25 +3
Lines 697 921 +224
==========================================
+ Hits 696 917 +221
- Misses 1 4 +3
|
kmike
reviewed
Jan 6, 2023
kmike
reviewed
Jan 6, 2023
BurnzZ
commented
Jan 9, 2023
BurnzZ
force-pushed
the
registry-features
branch
from
b699bd8 to
a59bd21
Compare
BurnzZ
changed the title
Gallaecio
approved these changes
Jan 9, 2023
kmike
reviewed
Jan 9, 2023
kmike
reviewed
Jan 12, 2023
kmike
reviewed
Jan 12, 2023
kmike
reviewed
Jan 13, 2023
kmike
reviewed
Jan 13, 2023
kmike
reviewed
Jan 13, 2023
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
kmike
reviewed
Jan 16, 2023
docs/page-objects/rules.rst
Outdated
|
|
||
| from web_poet import default_registry | ||
|
|
||
| item_cls = default_registry.page_object_for_item( |
There was a problem hiding this comment.
Do you mean renaming it something like page_object_cls_for_item? or maybe page_cls_for_item?
There was a problem hiding this comment.
The varible is named item_cls, but it contains page class, not item class.
There was a problem hiding this comment.
I totally missed that. Thanks! Updated. 1ab1a43
There was a problem hiding this comment.
You actually raised a good point - should we rename this method to page_cls_for_item, as it doesn't return an instantiated object?
There was a problem hiding this comment.
Yeah, I think that's much better. e86bf37
|
Thanks @BurnzZ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from scrapinghub/scrapy-poet#103.
TODO: