Add support for annotated deps in savefixture. #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gallaecio
approved these changes
Feb 27, 2024
|
LGTM, though it might need some updates after feedback on scrapinghub/web-poet#201 is addressed. |
kmike
approved these changes
Feb 28, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #190 +/- ##
==========================================
- Coverage 87.13% 86.68% -0.46%
==========================================
Files 15 15
Lines 917 916 -1
==========================================
- Hits 799 794 -5
- Misses 118 122 +4
|
wRAR
commented
Mar 4, 2024
| @@ -26,10 +26,10 @@ | |||
| "parsel >= 1.5.0", | |||
| "scrapy >= 2.6.0", | |||
| "sqlitedict >= 1.5.0", | |||
| "time_machine >= 2.2.0", | |||
| "time_machine >= 2.7.1", | |||
There was a problem hiding this comment.
New web-poet requires >= 2.7.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires scrapinghub/web-poet#201