Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix offset dialog option image with controls preset confirmation #6502

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

wookieejedi
Copy link
Member

The Popup Dialog for Confirm Control Preset Overwrite has the Yes and No buttons order switched compared to what they are usually set as. This means the images appear offset and do not look sharp against the background of the dialog box image. This PR switches the order to match and remove that visual bug. Albeit a very minor bug, but one I have heard from a few folks and noticed myself as well.

PR is tested and works as expected.

The Popup Dialog for `Confirm Control Preset Overwrite` has the Yes and No buttons order switched compared to what they are usually set as. This means the images appear offset and do not look sharp against the background of the dialog box image. This PR switches the order to match and remove that visual bug. Albeit a very minor bug, but one I have heard from a few folks and noticed myself as well.

PR is tested and works as expected.
@wookieejedi wookieejedi added cleanup A modification or rewrite of code to make it more understandable or easier to maintain. ui A feature or issue specific to the menus portion of the user interface labels Jan 2, 2025
@wookieejedi wookieejedi requested a review from z64555 as a code owner January 2, 2025 18:59
@wookieejedi wookieejedi added the controls A feature or issue related to input devices or actions controlled/triggered by them label Jan 2, 2025
@wookieejedi wookieejedi added this to the Release 25.0 milestone Jan 3, 2025
@wookieejedi wookieejedi merged commit 65dd3a7 into scp-fs2open:master Jan 5, 2025
16 checks passed
@wookieejedi wookieejedi deleted the fix-offset-ui-image branch January 5, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup A modification or rewrite of code to make it more understandable or easier to maintain. controls A feature or issue related to input devices or actions controlled/triggered by them ui A feature or issue specific to the menus portion of the user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants