refactor ai_mission_goal_achievable #5667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goober5000
added
refactor
Change `ai_mission_goal_achievable` to use the ship registry instead of looking up the target repeatedly.
Goober5000
force-pushed
the
refactor_mission_goal_achievable
branch
from
abda759 to
f98806b
Compare
Goober5000
added a commit
to Goober5000/fs2open.github.com
that referenced
this pull request
Oct 6, 2023
The ai-fly-to-ship goal was added early in FSO's development but never worked right. Until recently it crashed, and after the crash was fixed the AI would try to reach the target's exact position, causing repeated collisions. This folds ai-fly-to-ship into ai-stay-near-ship, since the behaviors are conceptually the same except for fly-to being satisfied as soon as the target is in range. This also adds a new "escort" mode usable by both behaviors. The default Volition behavior is to swoop toward the target in a long, graceful arc; the new mode generates a goal point and flies directly to that point. These can be toggled via an optional sexp parameter. There is also some minor cleanup and a new vec3d operator for convenience. Needed for Scroll; depends on scp-fs2open#5667.
Goober5000
added a commit
to Goober5000/fs2open.github.com
that referenced
this pull request
Oct 6, 2023
The ai-fly-to-ship goal was added early in FSO's development but never worked right. Until recently it could crash; and after the crash was fixed the AI would try to reach the target's exact position, causing repeated collisions. This folds ai-fly-to-ship into ai-stay-near-ship, since the behaviors are conceptually the same except for fly-to being satisfied as soon as the target is in range. This also adds a new "escort" mode usable by both behaviors. The default Volition behavior is to swoop toward the target in a long, graceful arc; the new mode generates a goal point and flies directly to that point. These can be toggled via an optional sexp parameter. There is also some minor cleanup and a new vec3d operator for convenience. Needed for Scroll; depends on scp-fs2open#5667.
Goober5000
added a commit
to Goober5000/fs2open.github.com
that referenced
this pull request
Oct 6, 2023
The ai-fly-to-ship goal was added early in FSO's development but never worked right. Until recently it could crash; and even aside from the crash the AI would try to reach the target's exact position, causing repeated collisions. This folds ai-fly-to-ship into ai-stay-near-ship, since the behaviors are conceptually the same except for fly-to being satisfied as soon as the target is in range. This also adds a new "escort" mode usable by both behaviors. The default Volition behavior is to swoop toward the target in a long, graceful arc; the new mode generates a goal point and flies directly to that point. These can be toggled via an optional sexp parameter. There is also some minor cleanup and a new vec3d operator for convenience. Needed for Scroll; depends on scp-fs2open#5667.
Goober5000
added
Requested by Active Mod
Baezon
approved these changes
Oct 15, 2023
Goober5000
added a commit
to Goober5000/fs2open.github.com
that referenced
this pull request
Oct 16, 2023
The ai-fly-to-ship goal was added early in FSO's development but never worked right. Until recently it could crash; and even aside from the crash the AI would try to reach the target's exact position, causing repeated collisions. This folds ai-fly-to-ship into ai-stay-near-ship, since the behaviors are conceptually the same except for fly-to being satisfied as soon as the target is in range. This also adds a new "escort" mode usable by both behaviors. The default Volition behavior is to swoop toward the target in a long, graceful arc; the new mode generates a goal point and flies directly to that point. These can be toggled via an optional sexp parameter. There is also some minor cleanup and a new vec3d operator for convenience. Needed for Scroll; depends on scp-fs2open#5667.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
ai_mission_goal_achievableto use the ship registry instead of looking up the target repeatedly.