Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for predicting arrival warp distance #5629

Merged
merged 8 commits into from
Oct 18, 2023

Conversation

Goober5000
Copy link
Contributor

This adds the ability to calculate the arrival distance of a ship using the default warp effect. There is a new option (in both FRED and qtFRED) to display a gray wireframe outline of the ship projected forward to its final location.

Credit to @Baezon for figuring out the math involved.

@Goober5000 Goober5000 added qtfred A feature or issue related to qtFred. fred A feature or issue related to the FReespace EDitor (FRED) Waiting for Stable Marks a pull request that is to be merged after the next stable release, due to a release cycle feature A totally new sort of functionality labels Sep 26, 2023
@Goober5000 Goober5000 marked this pull request as draft September 26, 2023 16:39
@Goober5000 Goober5000 marked this pull request as ready for review September 26, 2023 17:10
Copy link
Contributor

@JohnAFernandez JohnAFernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. It definitely ended up simpler than what I expected anyway. Just two quick things.

code/ship/shipfx.cpp Outdated Show resolved Hide resolved
code/ship/shipfx.cpp Outdated Show resolved Hide resolved
@Goober5000 Goober5000 force-pushed the arrival_warp_distance branch from 222b10f to 06d9e02 Compare October 15, 2023 17:48
@JohnAFernandez JohnAFernandez removed the Waiting for Stable Marks a pull request that is to be merged after the next stable release, due to a release cycle label Oct 16, 2023
@Goober5000 Goober5000 merged commit d10c59f into scp-fs2open:master Oct 18, 2023
14 checks passed
@Goober5000 Goober5000 deleted the arrival_warp_distance branch October 18, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A totally new sort of functionality fred A feature or issue related to the FReespace EDitor (FRED) qtfred A feature or issue related to qtFred.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants