add "special warp physics" to custom warpin parameters #5561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supercaps use a physics flag on warpin that makes them slow down faster than they would under the normal physics code. This adds that flag as an option for custom warp parameters. Since flags are not yet parsed when warp parameters are parsed, the code needs to skip ahead and peek at the flags in the same way as the weapon override.
Goober5000
added
enhancement
Baezon
approved these changes
Sep 27, 2023
| @@ -2728,7 +2728,7 @@ int parse_warp_params(const WarpParams *inherit_from, WarpDirection direction, c | |||
| if (accel_exp >= 0.0f) | |||
| params.accel_exp = accel_exp; | |||
| else | |||
| Warning(LOCATION, "%s specified as less than 0 on %s '%s'; value ignored", str, info_type_name, info_name); | |||
| error_display(0, "%s specified as less than 0 on %s '%s'; value ignored", str, info_type_name, info_name); | |||
There was a problem hiding this comment.
Is there a reason to prefer error_display? I'll admit that Warning(.. is much more intuitive to me than error_display(0, .., I can never remember which one 0 or 1 is.
There was a problem hiding this comment.
Increasing number = increasing severity, so 0 = warning and 1 = error.
The error_display function is specifically intended to be used while parsing. It displays the file name and line number of the file being parsed; and it also maintains warning and error counts for parsing, distinct from "all" warning and error counts.
Regular Warning and Error do not display anything about the file being parsed.
Goober5000
removed
the
Waiting for Stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supercaps use a physics flag on warpin that makes them slow down faster than they would under the normal physics code. This adds that flag as an option for custom warp parameters.
Since flags are not yet parsed when warp parameters are parsed, the code needs to skip ahead and peek at the flags in the same way as the weapon override.