Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to ignore jobs #298

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Conversation

asgrim
Copy link
Collaborator

@asgrim asgrim commented Nov 16, 2022

  • Adds new config key ignore_jobs (environment variable SCOUT_IGNORE_JOBS)
    • Value is a list<string>
    • Default value is ["horizon"] which will ignore all Laravel Horizon jobs
    • Example: SCOUT_IGNORE_JOBS="[\"horizon\",\"foo\"]" would ignore all jobs starting "horizon*" and "foo*" (e.g. horizon:work).
  • Tweaked the debug log output when sending metrics from Sending metrics from %d collected spans. to Sending metrics from request %s with %d collected spans. (to include the controller or job name, if found - note bug controllerOrJobName does not descend into span tree #296 needs to be fixed, at the moment a lot of (unknown) will be seen currently)
  • ignore() function now optionally takes a parameter as the "reason" for ignoring the request. This is output in debug log now, if set, e.g. Not sending payload, request has been ignored (horizon:work)

@asgrim asgrim added the enhancement New feature or request label Nov 16, 2022
@asgrim asgrim added this to the 8.7.0 milestone Nov 16, 2022
@asgrim asgrim self-assigned this Nov 16, 2022
@asgrim asgrim changed the title Add configuration ignore jobs Add configuration to ignore jobs Nov 16, 2022
@asgrim asgrim merged commit 023e5f1 into 8.7.x Nov 16, 2022
@asgrim asgrim deleted the add-configuration-ignore-jobs branch November 16, 2022 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant